Skip to content

Adding endpoint settings stores for Entity Framework - #5632

Merged
rbev merged 13 commits into
masterfrom
rhys/sql-config
Jul 28, 2026
Merged

Adding endpoint settings stores for Entity Framework#5632
rbev merged 13 commits into
masterfrom
rhys/sql-config

Conversation

@rbev

@rbev rbev commented Jul 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Implement IQueueAddressStore for EF persisters
  • Implement ITrialLicenseDataProvider for EF persisters
  • Implement IEndpointSettingsStore for EF persisters
  • Move test-only error insertion into test project
  • Improve test coverage on IQueueAddressStore, ITrialLicenseDataProvider, IEndpointSettingsStore

@rbev
rbev force-pushed the rhys/sql-config branch 4 times, most recently from cb5a137 to 6490609 Compare July 24, 2026 06:18
@rbev
rbev marked this pull request as ready for review July 24, 2026 06:38
@rbev rbev changed the title Adding endpoint settings stores Adding endpoint settings stores for Entity Framework Jul 24, 2026
@johnsimons

This comment was marked as resolved.

Sign in to view
@rbev
rbev force-pushed the rhys/sql-config branch from 030b6c2 to 5cee078 Compare July 27, 2026 00:51
johnsimons
johnsimons reviewed Jul 27, 2026
View reviewed changes
Comment thread src/ServiceControl.Persistence.EFCore/EntityConfigurations/EndpointSettingsConfiguration.cs Outdated
Comment thread src/ServiceControl.Persistence.EFCore/EntityConfigurations/EndpointSettingsConfiguration.cs
Comment thread src/ServiceControl.Persistence.EFCore/Implementation/EndpointSettingsStore.cs Outdated
Comment thread src/ServiceControl.Persistence.EFCore/Implementation/EndpointSettingsStore.cs Outdated
Comment thread src/ServiceControl.Persistence.EFCore/Implementation/EndpointSettingsStore.cs Outdated
Comment thread src/ServiceControl.Persistence.EFCore/Implementation/QueueAddressStore.cs Outdated
Comment thread src/ServiceControl.Persistence.EFCore/Implementation/QueueAddressStore.cs Outdated
Comment thread src/ServiceControl.Persistence.EFCore/Implementation/TrialLicenseDataProvider.cs Outdated
Comment thread src/ServiceControl.Persistence.Tests/TrialLicenseDataProviderTests.cs Outdated
Comment thread src/ServiceControl.Persistence.Tests/EndpointSettingsStoreTests.cs Outdated
@rbev
rbev force-pushed the rhys/sql-config branch from 80b31c5 to f4efb84 Compare July 27, 2026 05:53
rbev
rbev commented Jul 28, 2026
View reviewed changes
Comment thread src/ServiceControl.Persistence.EFCore/Implementation/QueueAddressStore.cs Outdated
@rbev
rbev force-pushed the rhys/sql-config branch 2 times, most recently from 96cfc30 to 570c8fd Compare July 28, 2026 03:58
@rbev
rbev requested a review from johnsimons July 28, 2026 04:34
@rbev
rbev force-pushed the rhys/sql-config branch from 51898b3 to 1a122af Compare July 28, 2026 04:35
@rbev
rbev force-pushed the rhys/sql-config branch from 986e8de to e95e0d6 Compare July 28, 2026 05:08
@rbev
rbev force-pushed the rhys/sql-config branch from eff82e5 to 61b7f67 Compare July 28, 2026 05:34
@rbev
rbev merged commit a234ef5 into master Jul 28, 2026
71 of 72 checks passed
@rbev
rbev deleted the rhys/sql-config branch July 28, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnsimons johnsimons johnsimons approved these changes
@warwickschroeder warwickschroeder warwickschroeder approved these changes
@abparticular abparticular Awaiting requested review from abparticular

Assignees

@rbev rbev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rbev @johnsimons @warwickschroeder